fix(webdriverjs): skip unloaded iframes #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbjorge
reviewed
Jun 7, 2023
dbjorge
reviewed
Jun 7, 2023
Zidious
previously requested changes
Jun 8, 2023
Comment on lines
+243
to
+248
| /* | ||
| When switchTo().frame() fails using chromedriver (but not geckodriver) | ||
| it puts the driver into a really bad state that is impossible to | ||
| recover from. So we need to switch back to the main window and then | ||
| go back to the desired iframe context | ||
| */ |
| @@ -0,0 +1,15 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
NBD - Do we want these fixtures to live in the axe-fixtures repo?
There was a problem hiding this comment.
Good question. I should probably move them since puppeteer also has this same issue. I'll add this as a tech debt ticket since I'd like to get this released without waiting to add it to the fixture repo.
There was a problem hiding this comment.
Co-authored-by: Gabe <41127686+Zidious@users.noreply.github.com>
Zidious
approved these changes
Jun 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #744